]> git.ipfire.org Git - thirdparty/kmod.git/commitdiff
testsuite: remove unused parameters
authorEmil Velikov <emil.l.velikov@gmail.com>
Thu, 29 May 2025 14:31:36 +0000 (15:31 +0100)
committerLucas De Marchi <lucas.de.marchi@gmail.com>
Wed, 11 Jun 2025 12:54:40 +0000 (07:54 -0500)
As of previous commit, neither fd_cmp_regex nor fd_cmp_exact needs the
test fixture. Remove the unused parameter and make the compiler happy
;-)

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/361
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
testsuite/testsuite.c

index 545dda74e090c76082b0084834be6162aba3b808..785f45d063024918ffecd37db5e116e15ca350e5 100644 (file)
@@ -434,7 +434,7 @@ static bool fd_cmp_regex_one(const char *pattern, const char *s)
  * read fd and fd_match, checking the first matches the regex of the second,
  * line by line
  */
-static bool fd_cmp_regex(struct fd_cmp *fd_cmp, const struct test *t)
+static bool fd_cmp_regex(struct fd_cmp *fd_cmp)
 {
        char *p, *p_match;
        int done = 0, done_match = 0, r;
@@ -525,7 +525,7 @@ static bool fd_cmp_regex(struct fd_cmp *fd_cmp, const struct test *t)
 }
 
 /* read fd and fd_match, checking they match exactly */
-static bool fd_cmp_exact(struct fd_cmp *fd_cmp, const struct test *t)
+static bool fd_cmp_exact(struct fd_cmp *fd_cmp)
 {
        int r, rmatch, done = 0;
 
@@ -629,9 +629,9 @@ static bool test_run_parent_check_outputs(const struct test *t, int fdout, int f
                                        goto out;
 
                                if (t->output.regex)
-                                       ret = fd_cmp_regex(fd_cmp, t);
+                                       ret = fd_cmp_regex(fd_cmp);
                                else
-                                       ret = fd_cmp_exact(fd_cmp, t);
+                                       ret = fd_cmp_exact(fd_cmp);
 
                                if (!ret) {
                                        err = -1;