pinctrl: nomadik: fix dereference of error pointer

If nmk_gpio_populate_chip() returns an error, avoid deferencing its
return value.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-gpio/5ee722f8-7582-420d-8477-45be6acde90f@moroto.mountain/
Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
Link: https://lore.kernel.org/r/20240306-mbly-gpio-err-fix-v1-1-a3605ba2336f@bootlin.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
index 47d5484f6bdf331044d04d365417e64215ef9d14..cb0f0d5a5e45686dccfc6abb54ac2bd922c9ddde 100644 (file)
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
@@ -1228,9 +1228,10 @@ static int nmk_pinctrl_probe(struct platform_device *pdev)
                if (IS_ERR(nmk_chip))
                        dev_err(&pdev->dev,
                                "could not populate nmk chip struct - continue anyway\n");
+               else
+                       /* We are NOT compatible with mobileye,eyeq5-gpio. */
+                       BUG_ON(nmk_chip->is_mobileye_soc);
                fwnode_handle_put(gpio_fwnode);
-               /* We are NOT compatible with mobileye,eyeq5-gpio. */
-               BUG_ON(nmk_chip->is_mobileye_soc);
        }
 
        prcm_fwnode = fwnode_find_reference(fwnode, "prcm", 0);