]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ALSA: hda/tas2781: Fix error code tas2781_read_acpi()
authorDan Carpenter <dan.carpenter@linaro.org>
Sat, 30 Nov 2024 10:08:18 +0000 (13:08 +0300)
committerTakashi Iwai <tiwai@suse.de>
Sun, 1 Dec 2024 08:51:33 +0000 (09:51 +0100)
Return an error code if acpi_get_subsystem_id() fails.  Don't return
success.

Fixes: 4e7035a75da9 ("ALSA: hda/tas2781: Add speaker id check for ASUS projects")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/ef773f8a-a61d-478b-9e81-41a38a75c77b@stanley.mountain
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/tas2781_hda_i2c.c

index 45cfb5a6f309c889c72c4db6241651be1dae5d51..8ec03bda85f32fbe903c3f1b2fcd366d01e40a89 100644 (file)
@@ -143,6 +143,7 @@ static int tas2781_read_acpi(struct tasdevice_priv *p, const char *hid)
        sub = acpi_get_subsystem_id(ACPI_HANDLE(physdev));
        if (IS_ERR(sub)) {
                dev_err(p->dev, "Failed to get SUBSYS ID.\n");
+               ret = PTR_ERR(sub);
                goto err;
        }
        /* Speaker id was needed for ASUS projects. */