]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
accel/habanalabs/gaudi2: read preboot status after recovering from dirty state
authorKonstantin Sinyuk <konstantin.sinyuk@intel.com>
Tue, 1 Oct 2024 12:52:27 +0000 (15:52 +0300)
committerKoby Elbaz <koby.elbaz@intel.com>
Thu, 25 Sep 2025 06:09:32 +0000 (09:09 +0300)
Dirty state can occur when the host VM undergoes a reset while the
device does not. In such a case, the driver must reset the device before
it can be used again. As part of this reset, the device capabilities
are zeroed. Therefore, the driver must read the Preboot status again to
learn the Preboot state, capabilities, and security configuration.

Signed-off-by: Konstantin Sinyuk <konstantin.sinyuk@intel.com>
Reviewed-by: Koby Elbaz <koby.elbaz@intel.com>
Signed-off-by: Koby Elbaz <koby.elbaz@intel.com>
drivers/accel/habanalabs/gaudi2/gaudi2.c

index 03dde63ed875506d8b4e81b2d158da54028163dc..b8c0689dba64057555ccaf90b8f12a61dab15e74 100644 (file)
@@ -3498,7 +3498,6 @@ static int gaudi2_early_init(struct hl_device *hdev)
        rc = hl_fw_read_preboot_status(hdev);
        if (rc) {
                if (hdev->reset_on_preboot_fail)
-                       /* we are already on failure flow, so don't check if hw_fini fails. */
                        hdev->asic_funcs->hw_fini(hdev, true, false);
                goto pci_fini;
        }
@@ -3510,6 +3509,13 @@ static int gaudi2_early_init(struct hl_device *hdev)
                        dev_err(hdev->dev, "failed to reset HW in dirty state (%d)\n", rc);
                        goto pci_fini;
                }
+
+               rc = hl_fw_read_preboot_status(hdev);
+               if (rc) {
+                       if (hdev->reset_on_preboot_fail)
+                               hdev->asic_funcs->hw_fini(hdev, true, false);
+                       goto pci_fini;
+               }
        }
 
        return 0;