]> git.ipfire.org Git - thirdparty/git.git/commitdiff
git-svn: allow "0" in SVN path components
authorEric Wong <e@80x24.org>
Wed, 30 Nov 2016 00:45:41 +0000 (00:45 +0000)
committerJunio C Hamano <gitster@pobox.com>
Mon, 12 Dec 2016 18:49:50 +0000 (10:49 -0800)
Blindly checking a path component for falsiness is unwise, as
"0" is false to Perl, but a valid pathname component for SVN
(or any filesystem).

Found via random code reading.

Signed-off-by: Eric Wong <e@80x24.org>
perl/Git/SVN/Ra.pm

index e7646968011234c09e1565577357a7678c015762..56ad9870bcfdfae68bd0fb5b57aa73e208bcb0fd 100644 (file)
@@ -606,7 +606,7 @@ sub minimize_url {
                        my $latest = $ra->get_latest_revnum;
                        $ra->get_log("", $latest, 0, 1, 0, 1, sub {});
                };
-       } while ($@ && ($c = shift @components));
+       } while ($@ && defined($c = shift @components));
 
        return canonicalize_url($url);
 }