]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mctp: return -ENOPROTOOPT for unknown getsockopt options
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Tue, 2 Sep 2025 10:20:55 +0000 (03:20 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 4 Sep 2025 00:01:52 +0000 (17:01 -0700)
In mctp_getsockopt(), unrecognized options currently return -EINVAL.
In contrast, mctp_setsockopt() returns -ENOPROTOOPT for unknown
options.

Update mctp_getsockopt() to also return -ENOPROTOOPT for unknown
options. This aligns the behavior of getsockopt() and setsockopt(),
and matches the standard kernel socket API convention for handling
unsupported options.

Fixes: 99ce45d5e7db ("mctp: Implement extended addressing")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Link: https://patch.msgid.link/20250902102059.1370008-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mctp/af_mctp.c

index df4e8cf33899befeffc82044b68a70b38f3a9b74..685524800d70a0e213120905b6b1e7469689af9b 100644 (file)
@@ -425,7 +425,7 @@ static int mctp_getsockopt(struct socket *sock, int level, int optname,
                return 0;
        }
 
-       return -EINVAL;
+       return -ENOPROTOOPT;
 }
 
 /* helpers for reading/writing the tag ioc, handling compatibility across the