]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Removed pointless call to maybeReadVirginBody() for aborted entries.
authorAlex Rousskov <rousskov@measurement-factory.com>
Thu, 23 Jun 2011 21:03:57 +0000 (15:03 -0600)
committerAlex Rousskov <rousskov@measurement-factory.com>
Thu, 23 Jun 2011 21:03:57 +0000 (15:03 -0600)
No runtime changes expected.

Setting flags.do_next_read to zero and then calling maybeReadVirginBody() is
pointless because maybeReadVirginBody() does nothing but wasting cycles when
the flag is zero. Also, even if we do manage to read the virgin response body
somehow, we cannot write it to the aborted store entry anyway.

src/http.cc

index 114b9b7190341989b1722b358550ff51d79469fa..d1bfcc0438a0968f74b859b4227fb6ce7d862365 100644 (file)
@@ -1095,7 +1095,7 @@ HttpStateData::readReply(const CommIoCbParams &io)
     }
 
     if (EBIT_TEST(entry->flags, ENTRY_ABORTED)) {
-        maybeReadVirginBody();
+        // TODO: should we call abortTransaction() here?
         return;
     }