]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
More polite passphrase prompt
authorMarko Myllynen <myllynen@redhat.com>
Tue, 9 Oct 2018 14:13:34 +0000 (17:13 +0300)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Tue, 9 Oct 2018 14:26:03 +0000 (16:26 +0200)
Instead of

Please enter passphrase for disk <disk-name>!

use

Please enter passphrase for disk <disk-name>:

which is more polite and matches Plymouth convention.

src/cryptsetup/cryptsetup.c
src/shared/dissect-image.c
src/tty-ask-password-agent/tty-ask-password-agent.c

index b590d706767aa6099aa405547e1782f5be617f85..1ec40198b458662c2d5229eba90bc4a982812e77 100644 (file)
@@ -357,7 +357,7 @@ static int get_password(const char *vol, const char *src, usec_t until, bool acc
 
         name = name_buffer ? name_buffer : vol;
 
-        if (asprintf(&text, "Please enter passphrase for disk %s!", name) < 0)
+        if (asprintf(&text, "Please enter passphrase for disk %s:", name) < 0)
                 return log_oom();
 
         id = strjoina("cryptsetup:", disk_path);
@@ -373,7 +373,7 @@ static int get_password(const char *vol, const char *src, usec_t until, bool acc
 
                 assert(strv_length(passwords) == 1);
 
-                if (asprintf(&text, "Please enter passphrase for disk %s! (verification)", name) < 0)
+                if (asprintf(&text, "Please enter passphrase for disk %s (verification):", name) < 0)
                         return log_oom();
 
                 id = strjoina("cryptsetup-verification:", disk_path);
index 0429a55a9c80638e1f01f734c81fac8c25ebe907..b6e0534b5db5fea33609a331f779f78824f95076 100644 (file)
@@ -1095,7 +1095,7 @@ int dissected_image_decrypt_interactively(
 
                 z = strv_free(z);
 
-                r = ask_password_auto("Please enter image passphrase!", NULL, "dissect", "dissect", USEC_INFINITY, 0, &z);
+                r = ask_password_auto("Please enter image passphrase:", NULL, "dissect", "dissect", USEC_INFINITY, 0, &z);
                 if (r < 0)
                         return log_error_errno(r, "Failed to query for passphrase: %m");
 
index 2aa97a8d08e09dc3665b0140ed34d551cca3f2d8..690c7b0de918457593d786d49c1f5038643b6c88 100644 (file)
@@ -323,7 +323,7 @@ static int parse_password(const char *filename, char **wall) {
 
                 if (asprintf(&_wall,
                              "%s%sPassword entry required for \'%s\' (PID %u).\r\n"
-                             "Please enter password with the systemd-tty-ask-password-agent tool!",
+                             "Please enter password with the systemd-tty-ask-password-agent tool:",
                              strempty(*wall),
                              *wall ? "\r\n\r\n" : "",
                              message,