tests: string: Fail with a clear error code on invalid input

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

diff --git a/src/pakfire/string.c b/src/pakfire/string.c
index 4bca3ee84c8d6dbf369092abe4cd1e85c34495d4..09aa6037cc1982cf054432111f6706bfae0c2a42 100644 (file)
--- a/src/pakfire/string.c
+++ b/src/pakfire/string.c
@@ -657,7 +657,7 @@ int __pakfire_format_time(char* buffer, const size_t length, const time_t t) {
 
        // Values smaller than zero for t are invalid
        if (t < 0)
-               return 1;
+               return -EINVAL;
 
        if (t >= 86400)
                format = "%dd%Hh%Mm";

diff --git a/tests/libpakfire/string.c b/tests/libpakfire/string.c
index 706c0b4a2fd9e26598b8b9b306558ab77d0540d8..f569833fda5a794ace1c73f23ccc60a00e5d2427 100644 (file)
--- a/tests/libpakfire/string.c
+++ b/tests/libpakfire/string.c
@@ -307,8 +307,7 @@ static int test_format_time(const struct test* t) {
        char buffer[128];
 
        // Values smaller than zero
-       ASSERT_SUCCESS(pakfire_format_time(buffer, -1));
-       ASSERT_STRING_EQUALS(buffer, NULL);
+       ASSERT_ERROR(pakfire_format_time(buffer, -1), EINVAL);
 
        // Values greater than a day
        ASSERT_SUCCESS(pakfire_format_time(buffer, 86400));