]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
io_uring/register: use atomic_read/write for sq_flags migration
authorJens Axboe <axboe@kernel.dk>
Fri, 24 Jan 2025 21:32:25 +0000 (14:32 -0700)
committerJens Axboe <axboe@kernel.dk>
Fri, 24 Jan 2025 21:36:43 +0000 (14:36 -0700)
A previous commit changed all of the migration from the old to the new
ring for resizing to use READ/WRITE_ONCE. However, ->sq_flags is an
atomic_t, and while most archs won't complain on this, some will indeed
flag this:

io_uring/register.c:554:9: sparse: sparse: cast to non-scalar
io_uring/register.c:554:9: sparse: sparse: cast from non-scalar

Just use atomic_set/atomic_read for handling this case.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501242000.A2sKqaCL-lkp@intel.com/
Fixes: 2c5aae129f42 ("io_uring/register: document io_register_resize_rings() shared mem usage")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/register.c

index 0db181437ae3305e2e26bbd99192c6143132c17c..9a4d2fbce4aec6ae470bfc717261d1cdfb61479c 100644 (file)
@@ -552,7 +552,7 @@ overflow:
        ctx->cqe_cached = ctx->cqe_sentinel = NULL;
 
        WRITE_ONCE(n.rings->sq_dropped, READ_ONCE(o.rings->sq_dropped));
-       WRITE_ONCE(n.rings->sq_flags, READ_ONCE(o.rings->sq_flags));
+       atomic_set(&n.rings->sq_flags, atomic_read(&o.rings->sq_flags));
        WRITE_ONCE(n.rings->cq_flags, READ_ONCE(o.rings->cq_flags));
        WRITE_ONCE(n.rings->cq_overflow, READ_ONCE(o.rings->cq_overflow));