s4/torture: Test with level 4 with NETLOGON_CONTROL_SET_DBFLAG function

Change levels tested from 1 - 3 to 1 - 4 for NETLOGON_CONTROL_SET_DBFLAG

This change triggers a core dump in the server and so we add a knownfail
here. Following commit will fix (and remove known fail)

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15465
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

diff --git a/selftest/knownfail.d/netlogon.admin b/selftest/knownfail.d/netlogon.admin
new file mode 100644 (file)
index 0000000..054eefb
--- /dev/null
+++ b/selftest/knownfail.d/netlogon.admin
@@ -0,0 +1 @@
+^samba3.rpc.netlogon.admin.admin.LogonControl2Ex.nt4_dc

diff --git a/source4/torture/rpc/netlogon.c b/source4/torture/rpc/netlogon.c
index 8e37e1a643e40fb7b0fef95af49e4cf7e3046204..1f04af119ac041abb2d24ae426e8cffac7fa04b4 100644 (file)
--- a/source4/torture/rpc/netlogon.c
+++ b/source4/torture/rpc/netlogon.c
@@ -3993,6 +3993,7 @@ static bool test_DatabaseSync2(struct torture_context *tctx,
 /*
   try a netlogon LogonControl2Ex
 */
+
 static bool test_LogonControl2Ex(struct torture_context *tctx,
                                 struct dcerpc_pipe *p,
                                 struct cli_credentials *machine_credentials)
@@ -4066,7 +4067,7 @@ static bool test_LogonControl2Ex(struct torture_context *tctx,
        r.in.function_code = NETLOGON_CONTROL_SET_DBFLAG;
        r.in.data = &data;
 
-       for (i=1;i<4;i++) {
+       for (i=1;i<=4;i++) {
                r.in.level = i;
 
                torture_comment(tctx, "Testing LogonControl2Ex function code %s (%d) level %d\n",