lib/addgrps.c: add_groups(): Simplify redundant code with a goto

Reviewed-by: Serge Hallyn <serge@hallyn.com>
Signed-off-by: Alejandro Colomar <alx@kernel.org>

diff --git a/lib/addgrps.c b/lib/addgrps.c
index b64fa4978d85f43717ffd9351764b74c32c17b83..e65b06d2786adca8ab6eba1afc8d9b835afc7b87 100644 (file)
--- a/lib/addgrps.c
+++ b/lib/addgrps.c
@@ -88,11 +88,8 @@ add_groups(const char *list)
        }
 
        if (added) {
-               int  ret;
-
-               ret = setgroups (ngroups, grouplist);
-               free (grouplist);
-               return ret;
+               if (setgroups(ngroups, grouplist) == -1)
+                       goto free_gids;
        }
 
        free (grouplist);