re PR libstdc++/14078 (Manipulators are slow)

2004-02-10  Paolo Carlini  <pcarlini@suse.de>
	    Petur Runolfsson  <peturr02@ru.is>

	PR libstdc++/14078
	* include/std/std_istream.h (operator>>(__istream_type& (*)
	(__istream_type&)), operator>>(__ios_type& (*)(__ios_type&)),
	operator>>(ios_base& (*)(ios_base&))): Declare inline.
	* include/std/std_ostream.h (operator<<(__ostream_type& (*)
	(__ostream_type&)), operator<<(__ios_type& (*)(__ios_type&)),
	operator<<(ios_base& (*) (ios_base&))): Likewise.
	* testsuite/performance/27_io/fmtflags_manipulators.cc: New.

Co-Authored-By: Petur Runolfsson <peturr02@ru.is>
From-SVN: r77650

diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog
index 8bd9edc07d69c214d014e73aff144843e1d8ca67..9eef2c647e735a0dc87144e425dcb0c6e0955e4b 100644 (file)
--- a/libstdc++-v3/ChangeLog
+++ b/libstdc++-v3/ChangeLog
@@ -1,3 +1,15 @@
+2004-02-11  Paolo Carlini  <pcarlini@suse.de>
+           Petur Runolfsson  <peturr02@ru.is>
+
+       PR libstdc++/14078
+       * include/std/std_istream.h (operator>>(__istream_type& (*)
+       (__istream_type&)), operator>>(__ios_type& (*)(__ios_type&)),
+       operator>>(ios_base& (*)(ios_base&))): Declare inline.
+       * include/std/std_ostream.h (operator<<(__ostream_type& (*)
+       (__ostream_type&)), operator<<(__ios_type& (*)(__ios_type&)),
+       operator<<(ios_base& (*) (ios_base&))): Likewise.
+       * testsuite/performance/27_io/fmtflags_manipulators.cc: New.
+
 2004-02-10  Loren J. Rittle  <ljrittle@acm.org>
 
        PR libstdc++/14098

diff --git a/libstdc++-v3/include/std/std_istream.h b/libstdc++-v3/include/std/std_istream.h
index f22b503d6c68c8a636b88744aa0a7d0a00366432..a3a53ba73f6e28d3bc31351b04292dddc56b06c7 100644 (file)
--- a/libstdc++-v3/include/std/std_istream.h
+++ b/libstdc++-v3/include/std/std_istream.h
@@ -128,13 +128,13 @@ namespace std
        *  functions in constructs like "std::cin >> std::ws".  For more
        *  information, see the iomanip header.
       */
-      __istream_type&
+      inline __istream_type&
       operator>>(__istream_type& (*__pf)(__istream_type&));
 
-      __istream_type&
+      inline __istream_type&
       operator>>(__ios_type& (*__pf)(__ios_type&));
 
-      __istream_type&
+      inline __istream_type&
       operator>>(ios_base& (*__pf)(ios_base&));
       //@}
       

diff --git a/libstdc++-v3/include/std/std_ostream.h b/libstdc++-v3/include/std/std_ostream.h
index 27669549ce0382645df6ce82af172ca7f7bfcc0c..e3590f23515ce094dca9caa2b808beab746474c7 100644 (file)
--- a/libstdc++-v3/include/std/std_ostream.h
+++ b/libstdc++-v3/include/std/std_ostream.h
@@ -127,13 +127,13 @@ namespace std
        *  functions in constructs like "std::cout << std::endl".  For more
        *  information, see the iomanip header.
       */
-      __ostream_type&
+      inline __ostream_type&
       operator<<(__ostream_type& (*__pf)(__ostream_type&));
       
-      __ostream_type&
+      inline __ostream_type&
       operator<<(__ios_type& (*__pf)(__ios_type&));
       
-      __ostream_type&
+      inline __ostream_type&
       operator<<(ios_base& (*__pf) (ios_base&));
       //@}
 

diff --git a/libstdc++-v3/testsuite/performance/27_io/fmtflags_manipulators.cc b/libstdc++-v3/testsuite/performance/27_io/fmtflags_manipulators.cc
new file mode 100644 (file)
index 0000000..0ef4510
--- /dev/null
+++ b/libstdc++-v3/testsuite/performance/27_io/fmtflags_manipulators.cc
@@ -0,0 +1,69 @@
+// Copyright (C) 2004 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 2, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING.  If not, write to the Free
+// Software Foundation, 59 Temple Place - Suite 330, Boston, MA 02111-1307,
+// USA.
+
+// As a special exception, you may use this file as part of a free software
+// library without restriction.  Specifically, if other files instantiate
+// templates or use macros or inline functions from this file, or you compile
+// this file and link it with other files to produce an executable, this
+// file does not by itself cause the resulting executable to be covered by
+// the GNU General Public License.  This exception does not however
+// invalidate any other reasons why the executable file might be covered by
+// the GNU General Public License.
+
+#include <cstdlib>
+#include <sstream>
+#include <testsuite_performance.h>
+
+// libstdc++/14078
+int main(int argc, char** argv)
+{
+  using namespace std;
+  using namespace __gnu_test;
+
+  time_counter time;
+  resource_counter resource;
+
+  int iters = 50000000;
+  if (argc > 1)
+    iters = atoi(argv[1]);
+  
+  ostringstream os_s, os_m;
+
+  // setf
+  start_counters(time, resource);
+  for (int i = 0; i < iters; ++i)
+    {
+      os_s.setf(ios_base::uppercase);
+      os_s.unsetf(ios_base::uppercase);
+    }
+  stop_counters(time, resource);
+  report_performance(__FILE__, "setf", time, resource);
+  clear_counters(time, resource);
+
+  // manipulator
+  start_counters(time, resource);
+  for (int i = 0; i < iters; ++i)
+    {
+      os_m << uppercase;
+      os_m << nouppercase;
+    }
+  stop_counters(time, resource);
+  report_performance(__FILE__, "manipulator", time, resource);
+
+  return 0;
+}