]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: adc: ad7266: Fix variable checking bug
authorFernando Yang <hagisf@usp.br>
Mon, 3 Jun 2024 18:07:54 +0000 (15:07 -0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 8 Jun 2024 17:26:57 +0000 (18:26 +0100)
The ret variable was not checked after iio_device_release_direct_mode(),
which could possibly cause errors

Fixes: c70df20e3159 ("iio: adc: ad7266: claim direct mode during sensor read")
Signed-off-by: Fernando Yang <hagisf@usp.br>
Link: https://lore.kernel.org/r/20240603180757.8560-1-hagisf@usp.br
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ad7266.c

index 353a97f9c0860a29948cd6e5d8a375e39198816d..13ea8a1073d281d76d5ddb63afe04de93801f47f 100644 (file)
@@ -157,6 +157,8 @@ static int ad7266_read_raw(struct iio_dev *indio_dev,
                ret = ad7266_read_single(st, val, chan->address);
                iio_device_release_direct_mode(indio_dev);
 
+               if (ret < 0)
+                       return ret;
                *val = (*val >> 2) & 0xfff;
                if (chan->scan_type.sign == 's')
                        *val = sign_extend32(*val,