]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
vhost-scsi: fix argument order in tport allocation error message
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Sat, 13 Sep 2025 15:40:53 +0000 (08:40 -0700)
committerMichael S. Tsirkin <mst@redhat.com>
Mon, 15 Sep 2025 22:25:58 +0000 (18:25 -0400)
The error log in vhost_scsi_make_tport() prints the arguments in the
wrong order, producing confusing output. For example, when creating a
target with a name in WWNN format such as "fc.port1234", the log
looks like:

  Emulated fc.port1234 Address: FCP, exceeds max: 64

Instead, the message should report the emulated protocol type first,
followed by the configfs name as:

  Emulated FCP Address: fc.port1234, exceeds max: 64

Fix the argument order so the error log is consistent and clear.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Message-Id: <20250913154106.3995856-1-alok.a.tiwari@oracle.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
drivers/vhost/scsi.c

index abf51332a5c5595df00c63029715dc0fdf50f985..98e4f68f4e3cb6a6a3a0983e77577b95cb9ca1dc 100644 (file)
@@ -2884,7 +2884,7 @@ vhost_scsi_make_tport(struct target_fabric_configfs *tf,
 check_len:
        if (strlen(name) >= VHOST_SCSI_NAMELEN) {
                pr_err("Emulated %s Address: %s, exceeds"
-                       " max: %d\n", name, vhost_scsi_dump_proto_id(tport),
+                       " max: %d\n", vhost_scsi_dump_proto_id(tport), name,
                        VHOST_SCSI_NAMELEN);
                kfree(tport);
                return ERR_PTR(-EINVAL);