Use C11 atomics instead of atomic_decrement(_val)

Replace atomic_decrement and atomic_decrement_val with
atomic_fetch_add_relaxed.

Reviewed-by: DJ Delorie <dj@redhat.com>

diff --git a/htl/pt-create.c b/htl/pt-create.c
index ce52ed9f52210a4e4c7a049ebee817ec9ccfeeb1..36f138b49807519699229012f29671736a1167f4 100644 (file)
--- a/htl/pt-create.c
+++ b/htl/pt-create.c
@@ -262,7 +262,7 @@ failed_starting:
     }
 
   __pthread_setid (pthread->thread, NULL);
-  atomic_decrement (&__pthread_total);
+  atomic_fetch_add_relaxed (&__pthread_total, -1);
 failed_sigstate:
   __pthread_sigstate_destroy (pthread);
 failed_setup:

diff --git a/malloc/malloc.c b/malloc/malloc.c
index aea4993f1b9a6f14d2694da737bd7d89e07385a3..bfe19557379268eb72991b4c692a4fb8c6adabe8 100644 (file)
--- a/malloc/malloc.c
+++ b/malloc/malloc.c
@@ -3033,7 +3033,7 @@ munmap_chunk (mchunkptr p)
       || __glibc_unlikely (!powerof2 (mem & (pagesize - 1))))
     malloc_printerr ("munmap_chunk(): invalid pointer");
 
-  atomic_decrement (&mp_.n_mmaps);
+  atomic_fetch_add_relaxed (&mp_.n_mmaps, -1);
   atomic_fetch_add_relaxed (&mp_.mmapped_mem, -total_size);
 
   /* If munmap failed the process virtual memory address space is in a

diff --git a/manual/ipc.texi b/manual/ipc.texi
index 081b98fe29e0b3b5b7f4f916ad2085d170bd3825..46c049c3da548bb071f3f5950f92640d95033903 100644 (file)
--- a/manual/ipc.texi
+++ b/manual/ipc.texi
@@ -89,7 +89,7 @@ by @theglibc{}.
 @c
 @c Given the use atomic operations this function seems
 @c to be AS-safe.  It is AC-unsafe because there is still
-@c a window between atomic_decrement and the pthread_push
+@c a window between atomic_fetch_add_relaxed and the pthread_push
 @c of the handler that undoes that operation.  A cancellation
 @c at that point would fail to remove the process from the
 @c waiters count.

diff --git a/manual/llio.texi b/manual/llio.texi
index e55b02d8bd839827a352c751f11ad18114c32ed3..0dfcdad4341e94d672529bba03fab10f524b4d11 100644 (file)
--- a/manual/llio.texi
+++ b/manual/llio.texi
@@ -2569,7 +2569,7 @@ aiocb64}, since the LFS transparently replaces the old interface.
 @c      lll_lock (pd->lock) @asulock @aculock
 @c      atomic_increment ok
 @c      clone ok
-@c      atomic_decrement ok
+@c      atomic_fetch_add_relaxed ok
 @c      atomic_exchange_acq ok
 @c      lll_futex_wake ok
 @c      deallocate_stack dup

diff --git a/nptl/nptl_setxid.c b/nptl/nptl_setxid.c
index aa863c7ea8122ea01d1aa4cffe101bbb7c11270c..e709822b9befd57f6141bedd72d7c2a23fa3eb64 100644 (file)
--- a/nptl/nptl_setxid.c
+++ b/nptl/nptl_setxid.c
@@ -88,7 +88,7 @@ __nptl_setxid_sighandler (int sig, siginfo_t *si, void *ctx)
   self->setxid_futex = 1;
   futex_wake (&self->setxid_futex, 1, FUTEX_PRIVATE);
 
-  if (atomic_decrement_val (&xidcmd->cntr) == 0)
+  if (atomic_fetch_add_relaxed (&xidcmd->cntr, -1) == 1)
     futex_wake ((unsigned int *) &xidcmd->cntr, 1, FUTEX_PRIVATE);
 }
 libc_hidden_def (__nptl_setxid_sighandler)

diff --git a/nptl/pthread_create.c b/nptl/pthread_create.c
index 308db65cd4c148f8a119ed9025af194946aa2c80..e7e4ede6b2ef2ea3ab7ca8cec601377a45b2bb54 100644 (file)
--- a/nptl/pthread_create.c
+++ b/nptl/pthread_create.c
@@ -861,7 +861,7 @@ __pthread_create_2_1 (pthread_t *newthread, const pthread_attr_t *attr,
         NOTES above).  */
 
       /* Oops, we lied for a second.  */
-      atomic_decrement (&__nptl_nthreads);
+      atomic_fetch_add_relaxed (&__nptl_nthreads, -1);
 
       /* Free the resources.  */
       __nptl_deallocate_stack (pd);

diff --git a/nscd/nscd-client.h b/nscd/nscd-client.h
index fee2a15dcc323258cecd45c5fb8e472da9161792..ca9e6def1a88ff14c5e8b39f0e236aa8a30f95ae 100644 (file)
--- a/nscd/nscd-client.h
+++ b/nscd/nscd-client.h
@@ -421,7 +421,7 @@ __nscd_drop_map_ref (struct mapped_database *map, int *gc_cycle)
          return -1;
        }
 
-      if (atomic_decrement_val (&map->counter) == 0)
+      if (atomic_fetch_add_relaxed (&map->counter, -1) == 1)
        __nscd_unmap (map);
     }
 

diff --git a/nscd/nscd_getai.c b/nscd/nscd_getai.c
index a99a4d8142b89521f3ca1759f42d5d88e1103f61..8e4650ebaedc6d79bd5ccda6721551b0227dbbb5 100644 (file)
--- a/nscd/nscd_getai.c
+++ b/nscd/nscd_getai.c
@@ -198,7 +198,7 @@ __nscd_getai (const char *key, struct nscd_ai_result **result, int *h_errnop)
       if ((gc_cycle & 1) != 0 || ++nretries == 5 || retval == -1)
        {
          /* nscd is just running gc now.  Disable using the mapping.  */
-         if (atomic_decrement_val (&mapped->counter) == 0)
+         if (atomic_fetch_add_relaxed (&mapped->counter, -1) == 1)
            __nscd_unmap (mapped);
          mapped = NO_MAPPING;
        }

diff --git a/nscd/nscd_getgr_r.c b/nscd/nscd_getgr_r.c
index 3636c031ec9403c7b447ebc52eecb2c60d74740f..bde3b588a01274730e1b1d817dfff62fd4f60c15 100644 (file)
--- a/nscd/nscd_getgr_r.c
+++ b/nscd/nscd_getgr_r.c
@@ -312,7 +312,7 @@ nscd_getgr_r (const char *key, size_t keylen, request_type type,
       if ((gc_cycle & 1) != 0 || ++nretries == 5 || retval == -1)
        {
          /* nscd is just running gc now.  Disable using the mapping.  */
-         if (atomic_decrement_val (&mapped->counter) == 0)
+         if (atomic_fetch_add_relaxed (&mapped->counter, -1) == 1)
            __nscd_unmap (mapped);
          mapped = NO_MAPPING;
        }

diff --git a/nscd/nscd_gethst_r.c b/nscd/nscd_gethst_r.c
index 9becb620335d14d7becebe6c29ad96cc4e7463ee..31d13580a11e64792d6f02ecd7437884d4436eb3 100644 (file)
--- a/nscd/nscd_gethst_r.c
+++ b/nscd/nscd_gethst_r.c
@@ -440,7 +440,7 @@ nscd_gethst_r (const char *key, size_t keylen, request_type type,
       if ((gc_cycle & 1) != 0 || ++nretries == 5 || retval == -1)
        {
          /* nscd is just running gc now.  Disable using the mapping.  */
-         if (atomic_decrement_val (&mapped->counter) == 0)
+         if (atomic_fetch_add_relaxed (&mapped->counter, -1) == 1)
            __nscd_unmap (mapped);
          mapped = NO_MAPPING;
        }

diff --git a/nscd/nscd_getpw_r.c b/nscd/nscd_getpw_r.c
index 20986f44332fca42d2f43794b4c365f6b3968cae..82fdd17d8c39287a9d450ff25802116028dc9475 100644 (file)
--- a/nscd/nscd_getpw_r.c
+++ b/nscd/nscd_getpw_r.c
@@ -225,7 +225,7 @@ nscd_getpw_r (const char *key, size_t keylen, request_type type,
       if ((gc_cycle & 1) != 0 || ++nretries == 5 || retval == -1)
        {
          /* nscd is just running gc now.  Disable using the mapping.  */
-         if (atomic_decrement_val (&mapped->counter) == 0)
+         if (atomic_fetch_add_relaxed (&mapped->counter, -1) == 1)
            __nscd_unmap (mapped);
          mapped = NO_MAPPING;
        }

diff --git a/nscd/nscd_getserv_r.c b/nscd/nscd_getserv_r.c
index 42b875d024c674a6c46dd28be8308a8d5d650ca6..de843b33631e2c57ac4e0192c6f1027c586cf329 100644 (file)
--- a/nscd/nscd_getserv_r.c
+++ b/nscd/nscd_getserv_r.c
@@ -365,7 +365,7 @@ nscd_getserv_r (const char *crit, size_t critlen, const char *proto,
       if ((gc_cycle & 1) != 0 || ++nretries == 5 || retval == -1)
        {
          /* nscd is just running gc now.  Disable using the mapping.  */
-         if (atomic_decrement_val (&mapped->counter) == 0)
+         if (atomic_fetch_add_relaxed (&mapped->counter, -1) == 1)
            __nscd_unmap (mapped);
          mapped = NO_MAPPING;
        }

diff --git a/nscd/nscd_helper.c b/nscd/nscd_helper.c
index 8e66fa2548e87c9b24cade41339c83f4cef7f2cf..0651817a9944d48506c89caa2957bc15b03146d6 100644 (file)
--- a/nscd/nscd_helper.c
+++ b/nscd/nscd_helper.c
@@ -390,7 +390,7 @@ __nscd_get_mapping (request_type type, const char *key,
   struct mapped_database *oldval = *mappedp;
   *mappedp = result;
 
-  if (oldval != NULL && atomic_decrement_val (&oldval->counter) == 0)
+  if (oldval != NULL && atomic_fetch_add_relaxed (&oldval->counter, -1) == 1)
     __nscd_unmap (oldval);
 
   return result;

diff --git a/nscd/nscd_initgroups.c b/nscd/nscd_initgroups.c
index dfce76a06090d5bd2869f8a239bdef51866bd854..47b6deb0699eaa984691388d146ae5e01ddd83ab 100644 (file)
--- a/nscd/nscd_initgroups.c
+++ b/nscd/nscd_initgroups.c
@@ -166,7 +166,7 @@ __nscd_getgrouplist (const char *user, gid_t group, long int *size,
       if ((gc_cycle & 1) != 0 || ++nretries == 5 || retval == -1)
        {
          /* nscd is just running gc now.  Disable using the mapping.  */
-         if (atomic_decrement_val (&mapped->counter) == 0)
+         if (atomic_fetch_add_relaxed (&mapped->counter, -1) == 1)
            __nscd_unmap (mapped);
          mapped = NO_MAPPING;
        }

diff --git a/nscd/nscd_netgroup.c b/nscd/nscd_netgroup.c
index 7e51dd3d941e383ab97bc0f70dd4dda65c340e0b..11b7f3214c2fb08f2e08df86f0d984e7bfc9bda2 100644 (file)
--- a/nscd/nscd_netgroup.c
+++ b/nscd/nscd_netgroup.c
@@ -148,7 +148,7 @@ __nscd_setnetgrent (const char *group, struct __netgrent *datap)
       if ((gc_cycle & 1) != 0 || ++nretries == 5 || retval == -1)
        {
          /* nscd is just running gc now.  Disable using the mapping.  */
-         if (atomic_decrement_val (&mapped->counter) == 0)
+         if (atomic_fetch_add_relaxed (&mapped->counter, -1) == 1)
            __nscd_unmap (mapped);
          mapped = NO_MAPPING;
        }
@@ -272,7 +272,7 @@ __nscd_innetgr (const char *netgroup, const char *host, const char *user,
       if ((gc_cycle & 1) != 0 || ++nretries == 5 || retval == -1)
        {
          /* nscd is just running gc now.  Disable using the mapping.  */
-         if (atomic_decrement_val (&mapped->counter) == 0)
+         if (atomic_fetch_add_relaxed (&mapped->counter, -1) == 1)
            __nscd_unmap (mapped);
          mapped = NO_MAPPING;
        }