]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mfd: tps6594: Explicitly include bitfield.h
authorNathan Chancellor <nathan@kernel.org>
Fri, 5 Sep 2025 01:26:12 +0000 (18:26 -0700)
committerLee Jones <lee@kernel.org>
Thu, 11 Sep 2025 15:06:02 +0000 (16:06 +0100)
After a recent change that started using FIELD_GET() in tps6594-core.c,
there is an error when bitfield.h is not implicitly included, such as
when building allmodconfig for ARCH=hexagon:

  drivers/mfd/tps6594-core.c:767:7: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    767 |                 if (FIELD_GET(TPS65224_MASK_EN_PB_VSENSE_CONFIG, pwr_on) == TPS65224_EN_SEL_PB ||
        |                     ^

Explicitly include bitfield.h to resolve the errors.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: d766ca01c208 ("mfd: tps6594: Add power button functionality")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Michael Walle <mwalle@kernel.org>
Closes: https://lore.kernel.org/oe-kbuild-all/202509032356.LGa5hygM-lkp@intel.com/
Link: https://lore.kernel.org/r/20250904-mfd-tps6594-core-fix-bitfield-h-v1-1-5d0f00cfe58f@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/tps6594-core.c

index 7127af7142f54b1ecfc2c74110e7f5fedb37d56b..8b26c41274727988beba0a203bc2a27d826cde51 100644 (file)
@@ -10,6 +10,7 @@
  * Copyright (C) 2023 BayLibre Incorporated - https://www.baylibre.com/
  */
 
+#include <linux/bitfield.h>
 #include <linux/completion.h>
 #include <linux/delay.h>
 #include <linux/interrupt.h>