]> git.ipfire.org Git - thirdparty/git.git/commitdiff
xdiff: avoid signed vs. unsigned comparisons in xutils.c
authorDavid Aguilar <davvid@gmail.com>
Wed, 12 Feb 2025 06:04:18 +0000 (22:04 -0800)
committerJunio C Hamano <gitster@pobox.com>
Wed, 12 Feb 2025 17:41:17 +0000 (09:41 -0800)
The comparisons all involve comparisons against unsigned values.

Signed-off-by: David Aguilar <davvid@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
xdiff/xutils.c

index 169edff5ab982bf9ff2b1c970152759b8eb5e54c..444a108f87c0b698187c098de014404dcf5ad09c 100644 (file)
@@ -20,8 +20,6 @@
  *
  */
 
-#define DISABLE_SIGN_COMPARE_WARNINGS
-
 #include "xinclude.h"
 
 
@@ -377,7 +375,7 @@ static int xdl_format_hunk_hdr(long s1, long c1, long s2, long c2,
        nb += 3;
        if (func && funclen) {
                buf[nb++] = ' ';
-               if (funclen > sizeof(buf) - nb - 1)
+               if ((size_t)funclen > sizeof(buf) - nb - 1)
                        funclen = sizeof(buf) - nb - 1;
                memcpy(buf + nb, func, funclen);
                nb += funclen;
@@ -439,7 +437,7 @@ void* xdl_alloc_grow_helper(void *p, long nr, long *alloc, size_t size)
 {
        void *tmp = NULL;
        size_t n = ((LONG_MAX - 16) / 2 >= *alloc) ? 2 * *alloc + 16 : LONG_MAX;
-       if (nr > n)
+       if ((size_t)nr > n)
                n = nr;
        if (SIZE_MAX / size >= n)
                tmp = xdl_realloc(p, n * size);