]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/msm/dp: disable the opp table request even for dp_ctrl_off_link()
authorAbhinav Kumar <quic_abhinavk@quicinc.com>
Fri, 6 Dec 2024 04:31:33 +0000 (20:31 -0800)
committerAbhinav Kumar <quic_abhinavk@quicinc.com>
Thu, 12 Dec 2024 19:33:28 +0000 (11:33 -0800)
dp_ctrl_off_link() was created to handle a case where we received
a cable connect and then get a cable disconnect without the corresponding
dp_display_enable(). For such cases the pixel clock will be off but the
link clock will still be on. dp_ctrl_off_link() handles this case by
turning off the link clock only.

However, the vote removal to the opp table for this case was missed.
Remove the opp table vote in dp_ctrl_off_link().

Fixes: 375a126090b9 ("drm/msm/dp: tear down main link at unplug handle immediately")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/627487/
Link: https://lore.kernel.org/r/20241205-dp_mst-v1-2-f8618d42a99a@quicinc.com
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
drivers/gpu/drm/msm/dp/dp_ctrl.c

index a8069f7c4773f087229727dc38c9af0d6d84f863..9c463ae2f8fae916661fef1c7e225f55c1026478 100644 (file)
@@ -2070,6 +2070,7 @@ void msm_dp_ctrl_off_link(struct msm_dp_ctrl *msm_dp_ctrl)
 
        msm_dp_catalog_ctrl_mainlink_ctrl(ctrl->catalog, false);
 
+       dev_pm_opp_set_rate(ctrl->dev, 0);
        msm_dp_ctrl_link_clk_disable(&ctrl->msm_dp_ctrl);
 
        DRM_DEBUG_DP("Before, phy=%p init_count=%d power_on=%d\n",