]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drivers/perf: Fix ali_drw_pmu driver interrupt status clearing
authorJing Zhang <renyu.zj@linux.alibaba.com>
Thu, 22 Aug 2024 03:33:31 +0000 (11:33 +0800)
committerWill Deacon <will@kernel.org>
Fri, 23 Aug 2024 15:03:56 +0000 (16:03 +0100)
The alibaba_uncore_pmu driver forgot to clear all interrupt status
in the interrupt processing function. After the PMU counter overflow
interrupt occurred, an interrupt storm occurred, causing the system
to hang.

Therefore, clear the correct interrupt status in the interrupt handling
function to fix it.

Fixes: cf7b61073e45 ("drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710 SoC")
Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
Reviewed-by: Shuai Xue <xueshuai@linux.alibaba.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Link: https://lore.kernel.org/r/1724297611-20686-1-git-send-email-renyu.zj@linux.alibaba.com
Signed-off-by: Will Deacon <will@kernel.org>
drivers/perf/alibaba_uncore_drw_pmu.c

index 38a2947ae8130cd327b0f718cc8c73061090ebbb..c6ff1bc7d336b813719b7533a42748c1bb534c50 100644 (file)
@@ -400,7 +400,7 @@ static irqreturn_t ali_drw_pmu_isr(int irq_num, void *data)
                        }
 
                        /* clear common counter intr status */
-                       clr_status = FIELD_PREP(ALI_DRW_PMCOM_CNT_OV_INTR_MASK, 1);
+                       clr_status = FIELD_PREP(ALI_DRW_PMCOM_CNT_OV_INTR_MASK, status);
                        writel(clr_status,
                               drw_pmu->cfg_base + ALI_DRW_PMU_OV_INTR_CLR);
                }