]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Explicitly close a file to stop raising a ResourceWarning.
authorBrett Cannon <brett@python.org>
Fri, 5 Aug 2011 04:34:52 +0000 (21:34 -0700)
committerBrett Cannon <brett@python.org>
Fri, 5 Aug 2011 04:34:52 +0000 (21:34 -0700)
Lib/test/test_sysconfig.py

index 96f75f282d095c315122093c9927cb24b63dbdf4..241af8fc0d9df9c2e7e296d56efa9d32c8a66191 100644 (file)
@@ -306,19 +306,20 @@ class TestSysConfig(unittest.TestCase):
         env = os.environ.copy()
         env['MACOSX_DEPLOYMENT_TARGET'] = '10.1'
 
-        p = subprocess.Popen([
-                sys.executable, '-c',
-                'import sysconfig; print(sysconfig.get_platform())',
-            ],
-            stdout=subprocess.PIPE,
-            stderr=open('/dev/null'),
-            env=env)
-        test_platform = p.communicate()[0].strip()
-        test_platform = test_platform.decode('utf-8')
-        status = p.wait()
+        with open('/dev/null') as dev_null:
+            p = subprocess.Popen([
+                    sys.executable, '-c',
+                    'import sysconfig; print(sysconfig.get_platform())',
+                ],
+                stdout=subprocess.PIPE,
+                stderr=dev_null,
+                env=env)
+            test_platform = p.communicate()[0].strip()
+            test_platform = test_platform.decode('utf-8')
+            status = p.wait()
 
-        self.assertEqual(status, 0)
-        self.assertEqual(my_platform, test_platform)
+            self.assertEqual(status, 0)
+            self.assertEqual(my_platform, test_platform)
 
 
 class MakefileTests(unittest.TestCase):