]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
login-common: Remove unnecessary client_ref/unref from STARTTLS handling
authorTimo Sirainen <timo.sirainen@dovecot.fi>
Wed, 1 Nov 2017 19:41:18 +0000 (21:41 +0200)
committerTimo Sirainen <tss@dovecot.fi>
Thu, 2 Nov 2017 12:32:23 +0000 (14:32 +0200)
There used to be code between them that could have destroyed the connection,
but that was removed long time ago.

src/login-common/client-common.c

index 5c65aa5cd68c091045b931bbd395e7719c8911a3..9d9c230c12968ab219691315cd9baa02ac598f71 100644 (file)
@@ -409,10 +409,6 @@ static void client_start_tls(struct client *client)
 {
        int fd_ssl;
 
-       client_ref(client);
-       if (!client_unref(&client) || client->destroyed)
-               return;
-
        fd_ssl = ssl_proxy_alloc(client->fd, &client->ip, client->pool,
                                 client->set, client->ssl_set,
                                 &client->ssl_proxy);