]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
caif_virtio: fix wrong pointer check in cfv_probe()
authorVitaliy Shevtsov <v.shevtsov@mt-integration.ru>
Thu, 27 Feb 2025 18:46:27 +0000 (23:46 +0500)
committerJakub Kicinski <kuba@kernel.org>
Sat, 1 Mar 2025 02:04:23 +0000 (18:04 -0800)
del_vqs() frees virtqueues, therefore cfv->vq_tx pointer should be checked
for NULL before calling it, not cfv->vdev. Also the current implementation
is redundant because the pointer cfv->vdev is dereferenced before it is
checked for NULL.

Fix this by checking cfv->vq_tx for NULL instead of cfv->vdev before
calling del_vqs().

Fixes: 0d2e1a2926b1 ("caif_virtio: Introduce caif over virtio")
Signed-off-by: Vitaliy Shevtsov <v.shevtsov@mt-integration.ru>
Reviewed-by: Gerhard Engleder <gerhard@engleder-embedded.com>
Link: https://patch.msgid.link/20250227184716.4715-1-v.shevtsov@mt-integration.ru
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/caif/caif_virtio.c

index 7fea00c7ca8a6ae57feeeb150281fbaec3761445..c60386bf2d1a4a276cc7fb7a272e23fdc76a2b01 100644 (file)
@@ -745,7 +745,7 @@ err:
 
        if (cfv->vr_rx)
                vdev->vringh_config->del_vrhs(cfv->vdev);
-       if (cfv->vdev)
+       if (cfv->vq_tx)
                vdev->config->del_vqs(cfv->vdev);
        free_netdev(netdev);
        return err;