Optimization: Fs::Ufs::RebuildState constructor copied dir ptr (#1802)

Detected by Coverity. CID 1529599: Unnecessary object copies can affect
performance (COPY_INSTEAD_OF_MOVE).

diff --git a/src/fs/ufs/RebuildState.cc b/src/fs/ufs/RebuildState.cc
index 3551d53a58fb9b075a209eb42afcf154cdcdc7bf..2f97dd0ae00553477648dda500c41b217df1fbb4 100644 (file)
--- a/src/fs/ufs/RebuildState.cc
+++ b/src/fs/ufs/RebuildState.cc
@@ -29,7 +29,7 @@
 
 CBDATA_NAMESPACED_CLASS_INIT(Fs::Ufs,RebuildState);
 
-Fs::Ufs::RebuildState::RebuildState(RefCount<UFSSwapDir> aSwapDir) :
+Fs::Ufs::RebuildState::RebuildState(const RefCount<UFSSwapDir> &aSwapDir) :
     sd(aSwapDir),
     n_read(0),
     LogParser(nullptr),

diff --git a/src/fs/ufs/RebuildState.h b/src/fs/ufs/RebuildState.h
index 73226bcf821e71dba4989f8647a3fc50c0fdbad0..9f2ee9df84500c495c59ea1bdf82c536d8c3c9a2 100644 (file)
--- a/src/fs/ufs/RebuildState.h
+++ b/src/fs/ufs/RebuildState.h
@@ -28,7 +28,7 @@ class RebuildState
 public:
     static EVH RebuildStep;
 
-    RebuildState(RefCount<UFSSwapDir> sd);
+    RebuildState(const RefCount<UFSSwapDir> &sd);
     virtual ~RebuildState();
 
     virtual bool error() const;