http: drop the check for an empty proxy password before approving

credential_approve() already checks for a non-empty password before
saving, so there's no need to do the extra check here.

Signed-off-by: John Szakmeister <john@szakmeister.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/http.c b/http.c
index 60d01c6e83907f8e6f92d9308d48818a95c7dfdb..3aeabf0947d655359790fdadb5594519cd29d02c 100644 (file)
--- a/http.c
+++ b/http.c
@@ -1635,8 +1635,7 @@ static int handle_curl_result(struct slot_results *results)
 
        if (results->curl_result == CURLE_OK) {
                credential_approve(&http_auth);
-               if (proxy_auth.password)
-                       credential_approve(&proxy_auth);
+               credential_approve(&proxy_auth);
                credential_approve(&cert_auth);
                return HTTP_OK;
        } else if (results->curl_result == CURLE_SSL_CERTPROBLEM) {