]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: fec: fec_restart(): introduce a define for FEC_ECR_SPEED
authorMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 18 Jun 2025 12:00:06 +0000 (14:00 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 19 Jun 2025 22:27:53 +0000 (15:27 -0700)
Replace "1 << 5" for configuring 1000 MBit/s with a defined constant to
improve code readability and maintainability.

Reviewed-by: Wei Fang <wei.fang@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Link: https://patch.msgid.link/20250618-fec-cleanups-v4-6-c16f9a1af124@pengutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/fec_main.c

index 083b7e07a9d181457fd531e432fbda3b1a6d0c81..e4fc1baf114d42662daef2434d594c40ac25d205 100644 (file)
@@ -275,6 +275,7 @@ MODULE_PARM_DESC(macaddr, "FEC Ethernet MAC address");
 #define FEC_ECR_MAGICEN         BIT(2)
 #define FEC_ECR_SLEEP           BIT(3)
 #define FEC_ECR_EN1588          BIT(4)
+#define FEC_ECR_SPEED           BIT(5)
 #define FEC_ECR_BYTESWP         BIT(8)
 /* FEC RCR bits definition */
 #define FEC_RCR_LOOP            BIT(0)
@@ -1206,7 +1207,7 @@ fec_restart(struct net_device *ndev)
                /* 1G, 100M or 10M */
                if (ndev->phydev) {
                        if (ndev->phydev->speed == SPEED_1000)
-                               ecntl |= (1 << 5);
+                               ecntl |= FEC_ECR_SPEED;
                        else if (ndev->phydev->speed == SPEED_100)
                                rcntl &= ~FEC_RCR_10BASET;
                        else