]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mm/numa: remove unnecessary local variable in alloc_node_data()
authorYe Liu <liuye@kylinos.cn>
Sun, 27 Apr 2025 10:04:42 +0000 (18:04 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 13 May 2025 06:50:38 +0000 (23:50 -0700)
The temporary local variable 'nd' is redundant.  Directly assign the
virtual address to node_data[nid] to simplify the code.

No functional change.

Link: https://lkml.kernel.org/r/20250427100442.958352-4-ye.liu@linux.dev
Signed-off-by: Ye Liu <liuye@kylinos.cn>
Acked-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Liam Howlett <liam.howlett@oracle.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Rik van Riel <riel@surriel.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/numa.c

index f1787d7713a6bd14cb7cfe11441b54bb509702d1..7d5e06fe5bd4a2790b83dd7dbe646617f6476d8c 100644 (file)
--- a/mm/numa.c
+++ b/mm/numa.c
@@ -13,7 +13,6 @@ void __init alloc_node_data(int nid)
 {
        const size_t nd_size = roundup(sizeof(pg_data_t), SMP_CACHE_BYTES);
        u64 nd_pa;
-       void *nd;
        int tnid;
 
        /* Allocate node data.  Try node-local memory and then any node. */
@@ -21,7 +20,6 @@ void __init alloc_node_data(int nid)
        if (!nd_pa)
                panic("Cannot allocate %zu bytes for node %d data\n",
                      nd_size, nid);
-       nd = __va(nd_pa);
 
        /* report and initialize */
        pr_info("NODE_DATA(%d) allocated [mem %#010Lx-%#010Lx]\n", nid,
@@ -30,7 +28,7 @@ void __init alloc_node_data(int nid)
        if (tnid != nid)
                pr_info("    NODE_DATA(%d) on node %d\n", nid, tnid);
 
-       node_data[nid] = nd;
+       node_data[nid] = __va(nd_pa);
        memset(NODE_DATA(nid), 0, sizeof(pg_data_t));
 }