]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/mediatek: Set DRM mode configs accordingly
authorHsiao Chien Sung <shawn.sung@mediatek.com>
Wed, 19 Jun 2024 16:38:50 +0000 (00:38 +0800)
committerChun-Kuang Hu <chunkuang.hu@kernel.org>
Thu, 20 Jun 2024 13:57:36 +0000 (13:57 +0000)
Set DRM mode configs limitation according to the hardware capabilities
and pass the IGT checks as below:

- The test "graphics.IgtKms.kms_plane" requires a frame buffer with
  width of 4512 pixels (> 4096).
- The test "graphics.IgtKms.kms_cursor_crc" checks if the cursor size is
  defined, and run the test with cursor size from 1x1 to 512x512.

Please notice that the test conditions may change as IGT is updated.

Reviewed-by: CK Hu <ck.hu@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
Link: https://patchwork.kernel.org/project/dri-devel/patch/20240620-igt-v3-10-a9d62d2e2c7e@mediatek.com/
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
drivers/gpu/drm/mediatek/mtk_drm_drv.c
drivers/gpu/drm/mediatek/mtk_drm_drv.h

index 8e047043202b425dd3fe76ba5499de00a3588906..c9cad3a827376a2647d78b27d7b46cc684e88595 100644 (file)
@@ -294,6 +294,9 @@ static const struct mtk_mmsys_driver_data mt8188_vdosys0_driver_data = {
        .conn_routes = mt8188_mtk_ddp_main_routes,
        .num_conn_routes = ARRAY_SIZE(mt8188_mtk_ddp_main_routes),
        .mmsys_dev_num = 2,
+       .max_width = 8191,
+       .min_width = 1,
+       .min_height = 1,
 };
 
 static const struct mtk_mmsys_driver_data mt8192_mmsys_driver_data = {
@@ -308,6 +311,9 @@ static const struct mtk_mmsys_driver_data mt8195_vdosys0_driver_data = {
        .main_path = mt8195_mtk_ddp_main,
        .main_len = ARRAY_SIZE(mt8195_mtk_ddp_main),
        .mmsys_dev_num = 2,
+       .max_width = 8191,
+       .min_width = 1,
+       .min_height = 1,
 };
 
 static const struct mtk_mmsys_driver_data mt8195_vdosys1_driver_data = {
@@ -315,6 +321,9 @@ static const struct mtk_mmsys_driver_data mt8195_vdosys1_driver_data = {
        .ext_len = ARRAY_SIZE(mt8195_mtk_ddp_ext),
        .mmsys_id = 1,
        .mmsys_dev_num = 2,
+       .max_width = 8191,
+       .min_width = 2, /* 2-pixel align when ethdr is bypassed */
+       .min_height = 1,
 };
 
 static const struct of_device_id mtk_drm_of_ids[] = {
@@ -493,6 +502,15 @@ static int mtk_drm_kms_init(struct drm_device *drm)
                for (j = 0; j < private->data->mmsys_dev_num; j++) {
                        priv_n = private->all_drm_private[j];
 
+                       if (priv_n->data->max_width)
+                               drm->mode_config.max_width = priv_n->data->max_width;
+
+                       if (priv_n->data->min_width)
+                               drm->mode_config.min_width = priv_n->data->min_width;
+
+                       if (priv_n->data->min_height)
+                               drm->mode_config.min_height = priv_n->data->min_height;
+
                        if (i == CRTC_MAIN && priv_n->data->main_len) {
                                ret = mtk_crtc_create(drm, priv_n->data->main_path,
                                                      priv_n->data->main_len, j,
@@ -520,6 +538,10 @@ static int mtk_drm_kms_init(struct drm_device *drm)
                }
        }
 
+       /* IGT will check if the cursor size is configured */
+       drm->mode_config.cursor_width = drm->mode_config.max_width;
+       drm->mode_config.cursor_height = drm->mode_config.max_height;
+
        /* Use OVL device for all DMA memory allocations */
        crtc = drm_crtc_from_index(drm, 0);
        if (crtc)
index 78d698ede1bf806f86e403830a0823c5b69fde21..ce897984de51ee499d0156cd3237a1a91058f063 100644 (file)
@@ -46,6 +46,10 @@ struct mtk_mmsys_driver_data {
        bool shadow_register;
        unsigned int mmsys_id;
        unsigned int mmsys_dev_num;
+
+       u16 max_width;
+       u16 min_width;
+       u16 min_height;
 };
 
 struct mtk_drm_private {