]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wcn36xx: simplify wcn36xx_smd_open()
authorDaniel Mack <daniel@zonque.org>
Wed, 23 May 2018 08:14:59 +0000 (11:14 +0300)
committerKalle Valo <kvalo@codeaurora.org>
Fri, 25 May 2018 10:08:11 +0000 (13:08 +0300)
Drop the extra warning about failed allocations, both the core and the
only caller of this function will warn loud enough in such cases.

Signed-off-by: Daniel Mack <daniel@zonque.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/wcn36xx/smd.c

index 0a505b5e038b0dd540d027c77ef1d06807fb3502..43c8aa79fad436067bf1c9cdf2f6372150111566 100644 (file)
@@ -2494,21 +2494,15 @@ static void wcn36xx_ind_smd_work(struct work_struct *work)
 }
 int wcn36xx_smd_open(struct wcn36xx *wcn)
 {
-       int ret = 0;
        wcn->hal_ind_wq = create_freezable_workqueue("wcn36xx_smd_ind");
-       if (!wcn->hal_ind_wq) {
-               wcn36xx_err("failed to allocate wq\n");
-               ret = -ENOMEM;
-               goto out;
-       }
+       if (!wcn->hal_ind_wq)
+               return -ENOMEM;
+
        INIT_WORK(&wcn->hal_ind_work, wcn36xx_ind_smd_work);
        INIT_LIST_HEAD(&wcn->hal_ind_queue);
        spin_lock_init(&wcn->hal_ind_lock);
 
        return 0;
-
-out:
-       return ret;
 }
 
 void wcn36xx_smd_close(struct wcn36xx *wcn)