]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: dsa: dsa_loop: use int type to store negative error codes
authorQianfeng Rong <rongqianfeng@vivo.com>
Wed, 3 Sep 2025 12:34:03 +0000 (20:34 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 4 Sep 2025 14:26:44 +0000 (07:26 -0700)
Change the 'ret' variable in dsa_loop_init() from unsigned int to int, as
it needs to store either negative error codes or zero returned by
mdio_driver_register().

Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but can be confusing.  Additionally, assigning negative error
codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
flag is enabled.

No effect on runtime.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://patch.msgid.link/20250903123404.395946-1-rongqianfeng@vivo.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/dsa_loop.c

index ad907287a853a91e36ead3955907a394439900ab..8112515d545ea2daed85939bdec7eea28e91a178 100644 (file)
@@ -399,7 +399,8 @@ static int __init dsa_loop_init(void)
                .speed = SPEED_100,
                .duplex = DUPLEX_FULL,
        };
-       unsigned int i, ret;
+       unsigned int i;
+       int ret;
 
        for (i = 0; i < NUM_FIXED_PHYS; i++)
                phydevs[i] = fixed_phy_register(&status, NULL);