]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
xfs_repair: set args.geo in longform_dir2_entry_check_data
authorEric Sandeen <sandeen@sandeen.net>
Wed, 2 Sep 2015 22:40:50 +0000 (08:40 +1000)
committerDave Chinner <david@fromorbit.com>
Wed, 2 Sep 2015 22:40:50 +0000 (08:40 +1000)
Here's another one where we miss setting da_args->geo:

longform_dir2_entry_check_data
        struct xfs_da_args      da = {
                .dp = ip,
// .geo is unset
        };
...
libxfs_dir2_data_make_free(&da ...)
xfs_dir2_data_make_free
endptr = (char *)hdr + args->geo->blksize;
BOOM

Addresses-Coverity-Id: 1298008
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
repair/phase6.c

index 7e275cdaba0456fe854dff5355bc804cee9d0f15..e41bf201c486821f0c20ed9e4bcf0374186e0ab2 100644 (file)
@@ -1507,6 +1507,7 @@ longform_dir2_entry_check_data(
        int                     wantmagic;
        struct xfs_da_args      da = {
                .dp = ip,
+               .geo = mp->m_dir_geo,
        };