bcachefs: rcu_pending: don't invoke __call_rcu() under lock

In userspace we don't (yet) have an SRCU implementation, so call_srcu()
recurses.

But we don't want to be invoking it under the lock anyways.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

diff --git a/fs/bcachefs/rcu_pending.c b/fs/bcachefs/rcu_pending.c
index 40a20192eee8915af49bce0873caf9af7ea5e830..67522aa344a735c8d53be736fb1897f1c00435af 100644 (file)
--- a/fs/bcachefs/rcu_pending.c
+++ b/fs/bcachefs/rcu_pending.c
@@ -478,7 +478,9 @@ start_gp:
                 */
                if (!p->cb_armed) {
                        p->cb_armed = true;
+                       spin_unlock_irqrestore(&p->lock, flags);
                        __call_rcu(pending->srcu, &p->cb, rcu_pending_rcu_cb);
+                       goto free_node;
                } else {
                        __start_poll_synchronize_rcu(pending->srcu);
                }