net: stmmac: anarion: clean up interface parsing

anarion_config_dt() used a switch statement to check for the RGMII
modes, complete with an unnecessary "fallthrough", and also printed
the numerical value of the PHY interface mode on error. Clean this
up using the phy_interface_mode_is_rgmii() helper, and print the
English version of the PHY interface mode on error.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1u4FlV-000XjG-83@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c
index 232aae75269052126592207a05f16d0f90dca2fe..941ea724c64328e1ca8fa5a48f7c6e35a8220617 100644 (file)
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c
@@ -79,17 +79,11 @@ anarion_config_dt(struct platform_device *pdev,
 
        gmac->ctl_block = ctl_block;
 
-       switch (plat_dat->phy_interface) {
-       case PHY_INTERFACE_MODE_RGMII:
-               fallthrough;
-       case PHY_INTERFACE_MODE_RGMII_ID:
-       case PHY_INTERFACE_MODE_RGMII_RXID:
-       case PHY_INTERFACE_MODE_RGMII_TXID:
+       if (phy_interface_mode_is_rgmii(plat_dat->phy_interface)) {
                gmac->phy_intf_sel = GMAC_CONFIG_INTF_RGMII;
-               break;
-       default:
-               dev_err(&pdev->dev, "Unsupported phy-mode (%d)\n",
-                       plat_dat->phy_interface);
+       } else {
+               dev_err(&pdev->dev, "Unsupported phy-mode (%s)\n",
+                       phy_modes(plat_dat->phy_interface));
                return ERR_PTR(-ENOTSUPP);
        }