bfd: Change num_group to unsigned int

elf.c failed with to with GCC 10 as of

commit 906b3eb9df6c577d3f6e9c3ea5c9d7e4d1e90536
Author: Martin Liska <mliska@suse.cz>
Date:   Tue Mar 24 11:40:10 2020 +0100

    Improve endianess detection.

            PR lto/94249
            * plugin-api.h: Add more robust endianess detection.

binutils-gdb/bfd/elf.c: In function ‘setup_group’:
binutils-gdb/bfd/elf.c:740:35: error: overflow in conversion from ‘unsigned int’ to ‘int’ changes value from ‘num_group = 4294967295’ to ‘-1’ [-Werror=overflow]
  740 |     elf_tdata (abfd)->num_group = num_group = -1;
      |                                   ^~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [Makefile:1608: elf.lo] Error 1

Change num_group in elf_obj_tdata to unsigned int to compile with GCC 10.

	PR binutils/25717
	* elf-bfd.h (elf_obj_tdata): Change num_group to unsigned int.

(cherry picked from commit cda7e5603f6efd7c3716e45cc6ea11b70dd8daae)

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index fd102a9cfe0a0c88380716657023609960fd0b7f..f8abe540ba9c73b7977b88eb04428f7850ac6eb4 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2020-03-24  H.J. Lu  <hongjiu.lu@intel.com>
+
+       PR binutils/25717
+       * elf-bfd.h (elf_obj_tdata): Change num_group to unsigned int.
+
 2020-03-11  Alan Modra  <amodra@gmail.com>
 
        * elf64-ppc.c (ppc64_elf_inline_plt): Do increment rel in for loop.

diff --git a/bfd/elf-bfd.h b/bfd/elf-bfd.h
index cbbba153f4966926a9bf7c45020da39774d0ed25..1550a08b31a57c64b2d1bf7b20c6a0fd67c6ab3d 100644 (file)
--- a/bfd/elf-bfd.h
+++ b/bfd/elf-bfd.h
@@ -1937,7 +1937,7 @@ struct elf_obj_tdata
   struct sdt_note *sdt_note_head;
 
   Elf_Internal_Shdr **group_sect_ptr;
-  int num_group;
+  unsigned int num_group;
 
   /* Index into group_sect_ptr, updated by setup_group when finding a
      section's group.  Used to optimize subsequent group searches.  */