Prevent flickering when redrawing the TUI python window

tui_win_info::refresh_window first redraws the background window, then
tui_wrefresh draws the python text on top of it, which flickers.

By using wnoutrefresh for the background window, the actual drawing on
the screen is only done once, without flickering.

gdb/ChangeLog:

2021-05-24  Hannes Domani  <ssbssa@yahoo.de>

	* python/py-tui.c (tui_py_window::refresh_window):
	Avoid flickering.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 480d204232a6d054bd16361cc05fd8a744712c03..b24a24be267d48df3500654085c3200d4f7db032 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2021-05-24  Hannes Domani  <ssbssa@yahoo.de>
+
+       * python/py-tui.c (tui_py_window::refresh_window):
+       Avoid flickering.
+
 2021-05-23  Tom de Vries  <tdevries@suse.de>
 
        PR tdep/27822

diff --git a/gdb/python/py-tui.c b/gdb/python/py-tui.c
index 72e9c0d5e2b11e065b24da66a9a4b2df9ad287c9..22f4b0ffd43afebb08013ad4301a29114e7ab3fd 100644 (file)
--- a/gdb/python/py-tui.c
+++ b/gdb/python/py-tui.c
@@ -91,12 +91,14 @@ public:
 
   void refresh_window () override
   {
-    tui_win_info::refresh_window ();
     if (m_inner_window != nullptr)
       {
+       wnoutrefresh (handle.get ());
        touchwin (m_inner_window.get ());
        tui_wrefresh (m_inner_window.get ());
       }
+    else
+      tui_win_info::refresh_window ();
   }
 
   /* Erase and re-box the window.  */