]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: renesas: rzg2l: Fix missing of_node_put() call
authorFabrizio Castro <fabrizio.castro.jz@renesas.com>
Wed, 5 Mar 2025 16:37:51 +0000 (16:37 +0000)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Thu, 6 Mar 2025 15:41:30 +0000 (16:41 +0100)
of_parse_phandle_with_fixed_args() requires its caller to
call into of_node_put() on the node pointer from the output
structure, but such a call is currently missing.

Call into of_node_put() to rectify that.

Fixes: c4c4637eb57f ("pinctrl: renesas: Add RZ/G2L pin and gpio controller driver")
Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/20250305163753.34913-3-fabrizio.castro.jz@renesas.com
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
drivers/pinctrl/renesas/pinctrl-rzg2l.c

index 9280bc37a6232d932d9c9437a167f4350083010f..c72e250f4a1544a15b81ffa246d1aee3b626fd98 100644 (file)
@@ -2763,6 +2763,8 @@ static int rzg2l_gpio_register(struct rzg2l_pinctrl *pctrl)
        if (ret)
                return dev_err_probe(pctrl->dev, ret, "Unable to parse gpio-ranges\n");
 
+       of_node_put(of_args.np);
+
        if (of_args.args[0] != 0 || of_args.args[1] != 0 ||
            of_args.args[2] != pctrl->data->n_port_pins)
                return dev_err_probe(pctrl->dev, -EINVAL,