]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
HID: mcp-2221: Replace manual comparison with min() macro
authorYu Jiaoliang <yujiaoliang@vivo.com>
Thu, 19 Jun 2025 02:47:41 +0000 (10:47 +0800)
committerJiri Kosina <jkosina@suse.com>
Fri, 20 Jun 2025 07:03:04 +0000 (09:03 +0200)
This improves code readability by using the standard
kernel macro for minimal value selection while maintaining identical
functionality.

Signed-off-by: Yu Jiaoliang <yujiaoliang@vivo.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/hid-mcp2221.c

index 3bc5884e572edec31759e78f2852712f61b8683d..fcfe9370a8872d08e2b032f5c969385908789743 100644 (file)
@@ -18,6 +18,7 @@
 #include <linux/i2c.h>
 #include <linux/gpio/driver.h>
 #include <linux/iio/iio.h>
+#include <linux/minmax.h>
 #include "hid-ids.h"
 
 /* Commands codes in a raw output report */
@@ -262,10 +263,7 @@ static int mcp_i2c_write(struct mcp2221 *mcp,
 
        idx = 0;
        sent  = 0;
-       if (msg->len < 60)
-               len = msg->len;
-       else
-               len = 60;
+       len = min(msg->len, 60);
 
        do {
                mcp->txbuf[0] = type;
@@ -292,10 +290,7 @@ static int mcp_i2c_write(struct mcp2221 *mcp,
                        break;
 
                idx = idx + len;
-               if ((msg->len - sent) < 60)
-                       len = msg->len - sent;
-               else
-                       len = 60;
+               len = min(msg->len - sent, 60);
 
                /*
                 * Testing shows delay is needed between successive writes