]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: r8188eu: drop removal/stop check in dump_mgntframe_and_wait_ack
authorMartin Kaiser <martin@kaiser.cx>
Mon, 7 Nov 2022 20:28:24 +0000 (21:28 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 8 Nov 2022 15:29:55 +0000 (16:29 +0100)
We can remove the checks for bDriverStopped and bSurpriseRemoved in
dump_mgntframe_and_wait_ack.

The code path from this function looks like

dump_mgntframe_and_wait_ack
   rtl8188eu_mgnt_xmit
      rtw_dump_xframe
         loop over all fragments

rtw_write_port is called for each fragment. bSurpriseRemoved and
bDriverStopped are checked in rtw_write_port.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20221107202824.61431-4-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_mlme_ext.c

index bfd6afd7266e3929c1a9981cad0d8a5312dbbc75..be33489d3dfddaf950061a38fb4f7f9078d06008 100644 (file)
@@ -3988,9 +3988,6 @@ s32 dump_mgntframe_and_wait_ack(struct adapter *padapter, struct xmit_frame *pmg
        u32 timeout_ms = 500;/*   500ms */
        struct xmit_priv        *pxmitpriv = &padapter->xmitpriv;
 
-       if (padapter->bSurpriseRemoved || padapter->bDriverStopped)
-               return -1;
-
        mutex_lock(&pxmitpriv->ack_tx_mutex);
        pxmitpriv->ack_tx = true;