USB: chipidea: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Acked-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/chipidea/ci.h b/drivers/usb/chipidea/ci.h
index 98b7cb3d00641fdef37679c7a4144312e4ce6ca7..0bf244d505442932d7660640029beebb66c2e0e0 100644 (file)
--- a/drivers/usb/chipidea/ci.h
+++ b/drivers/usb/chipidea/ci.h
@@ -450,7 +450,7 @@ void hw_phymode_configure(struct ci_hdrc *ci);
 
 void ci_platform_configure(struct ci_hdrc *ci);
 
-int dbg_create_files(struct ci_hdrc *ci);
+void dbg_create_files(struct ci_hdrc *ci);
 
 void dbg_remove_files(struct ci_hdrc *ci);
 #endif /* __DRIVERS_USB_CHIPIDEA_CI_H */

diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 33ae87fa3ff3785f8440bedf2b5f15795d03169a..85fc6db48e449214e092c7a36443995d7544b713 100644 (file)
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -1062,9 +1062,7 @@ static int ci_hdrc_probe(struct platform_device *pdev)
                ci_hdrc_otg_fsm_start(ci);
 
        device_set_wakeup_capable(&pdev->dev, true);
-       ret = dbg_create_files(ci);
-       if (ret)
-               goto stop;
+       dbg_create_files(ci);
 
        ret = sysfs_create_group(&dev->kobj, &ci_attr_group);
        if (ret)

diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c
index ce648cb3ed9479f48b92e91c33627596d67d56c3..fcc91a338875e64d8f6bc68f08a3d03bc347b8c1 100644 (file)
--- a/drivers/usb/chipidea/debug.c
+++ b/drivers/usb/chipidea/debug.c
@@ -340,54 +340,28 @@ DEFINE_SHOW_ATTRIBUTE(ci_registers);
  *
  * This function returns an error code
  */
-int dbg_create_files(struct ci_hdrc *ci)
+void dbg_create_files(struct ci_hdrc *ci)
 {
-       struct dentry *dent;
-
        ci->debugfs = debugfs_create_dir(dev_name(ci->dev), NULL);
-       if (!ci->debugfs)
-               return -ENOMEM;
-
-       dent = debugfs_create_file("device", S_IRUGO, ci->debugfs, ci,
-                                  &ci_device_fops);
-       if (!dent)
-               goto err;
-
-       dent = debugfs_create_file("port_test", S_IRUGO | S_IWUSR, ci->debugfs,
-                                  ci, &ci_port_test_fops);
-       if (!dent)
-               goto err;
-
-       dent = debugfs_create_file("qheads", S_IRUGO, ci->debugfs, ci,
-                                  &ci_qheads_fops);
-       if (!dent)
-               goto err;
 
-       dent = debugfs_create_file("requests", S_IRUGO, ci->debugfs, ci,
-                                  &ci_requests_fops);
-       if (!dent)
-               goto err;
+       debugfs_create_file("device", S_IRUGO, ci->debugfs, ci,
+                           &ci_device_fops);
+       debugfs_create_file("port_test", S_IRUGO | S_IWUSR, ci->debugfs, ci,
+                           &ci_port_test_fops);
+       debugfs_create_file("qheads", S_IRUGO, ci->debugfs, ci,
+                           &ci_qheads_fops);
+       debugfs_create_file("requests", S_IRUGO, ci->debugfs, ci,
+                           &ci_requests_fops);
 
        if (ci_otg_is_fsm_mode(ci)) {
-               dent = debugfs_create_file("otg", S_IRUGO, ci->debugfs, ci,
-                                       &ci_otg_fops);
-               if (!dent)
-                       goto err;
+               debugfs_create_file("otg", S_IRUGO, ci->debugfs, ci,
+                                   &ci_otg_fops);
        }
 
-       dent = debugfs_create_file("role", S_IRUGO | S_IWUSR, ci->debugfs, ci,
-                                  &ci_role_fops);
-       if (!dent)
-               goto err;
-
-       dent = debugfs_create_file("registers", S_IRUGO, ci->debugfs, ci,
-                               &ci_registers_fops);
-
-       if (dent)
-               return 0;
-err:
-       debugfs_remove_recursive(ci->debugfs);
-       return -ENOMEM;
+       debugfs_create_file("role", S_IRUGO | S_IWUSR, ci->debugfs, ci,
+                           &ci_role_fops);
+       debugfs_create_file("registers", S_IRUGO, ci->debugfs, ci,
+                           &ci_registers_fops);
 }
 
 /**