]> git.ipfire.org Git - thirdparty/kmod.git/commitdiff
libkmod: don't use %m on strbuf_to_vector() failure
authorEmil Velikov <emil.l.velikov@gmail.com>
Wed, 4 Jun 2025 16:16:25 +0000 (17:16 +0100)
committerLucas De Marchi <lucas.de.marchi@gmail.com>
Wed, 11 Jun 2025 13:03:26 +0000 (08:03 -0500)
The function does not set the errno on overflow conditions, so the ERR()
will produce (somewhat) arbitrary strerror. Similar to other places
throughout the code base - just use ENOMEM.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/368
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
libkmod/libkmod-builtin.c

index f54d876b0fdb2298b226788bf460fdcbaf8f6ee9..f1b836a9f519aaa200fb953b8db18418076f0f0c 100644 (file)
@@ -167,7 +167,7 @@ ssize_t kmod_builtin_get_modinfo(struct kmod_ctx *ctx, const char *modname,
                *modinfo = strbuf_to_vector(&buf, (size_t)count);
                if (*modinfo == NULL) {
                        count = -ENOMEM;
-                       ERR(ctx, "strbuf_to_vector: %m\n");
+                       ERR(ctx, "strbuf_to_vector: %s\n", strerror(ENOMEM));
                }
        }