]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
scsi: scsi_transport_srp: Replace min/max nesting with clamp()
authorLi Haoran <li.haoran7@zte.com.cn>
Mon, 31 Mar 2025 07:55:11 +0000 (15:55 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 3 Apr 2025 14:54:31 +0000 (10:54 -0400)
This patch replaces min(a, max(b, c)) by clamp(val, lo, hi) in the SRP
transport layer. The clamp() macro explicitly expresses the intent of
constraining a value within bounds, improving code readability.

Signed-off-by: Li Haoran <li.haoran7@zte.com.cn>
Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
Link: https://lore.kernel.org/r/202503311555115618U8Md16mKpRYOIy2TOmB6@zte.com.cn
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_transport_srp.c

index 64f6b22e8cc0c9663b3b7fb736b7135e7659a539..aeb58a9e6b7f1d1d07db70ce32d92895854bc66b 100644 (file)
@@ -388,7 +388,7 @@ static void srp_reconnect_work(struct work_struct *work)
                             "reconnect attempt %d failed (%d)\n",
                             ++rport->failed_reconnects, res);
                delay = rport->reconnect_delay *
-                       min(100, max(1, rport->failed_reconnects - 10));
+                       clamp(rport->failed_reconnects - 10, 1, 100);
                if (delay > 0)
                        queue_delayed_work(system_long_wq,
                                           &rport->reconnect_work, delay * HZ);