]> git.ipfire.org Git - pakfire.git/commitdiff
buildservice: Tidy up creating the daemon control connection
authorMichael Tremer <michael.tremer@ipfire.org>
Sun, 15 Sep 2024 02:36:36 +0000 (02:36 +0000)
committerMichael Tremer <michael.tremer@ipfire.org>
Sun, 15 Sep 2024 02:36:36 +0000 (02:36 +0000)
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
src/libpakfire/buildservice.c

index a4fcc70e0d1553affcbc4ace58fbb42afa74d9c9..fa52918974ad5bc236d4b5ad3b9eb0c90e153614 100644 (file)
@@ -1027,16 +1027,10 @@ ERROR:
 int pakfire_buildservice_daemon(struct pakfire_buildservice* service, pakfire_xfer_recv_callback recv,
                pakfire_xfer_send_callback send, pakfire_xfer_close_callback close, void* data) {
        struct pakfire_xfer* xfer = NULL;
-       char url[PATH_MAX];
        int r;
 
-       // Compose the URL
-       r = pakfire_string_set(url, "/api/v1/builders/control");
-       if (r)
-               goto ERROR;
-
        // Create a new xfer
-       r = pakfire_buildservice_create_xfer(&xfer, service, url);
+       r = pakfire_buildservice_create_xfer(&xfer, service, "/api/v1/builders/control");
        if (r)
                goto ERROR;
 
@@ -1055,6 +1049,11 @@ int pakfire_buildservice_daemon(struct pakfire_buildservice* service, pakfire_xf
        if (r)
                goto ERROR;
 
+       return 0;
+
 ERROR:
+       if (xfer)
+               pakfire_xfer_unref(xfer);
+
        return r;
 }