]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
btrfs: fix front delete range calculation for RAID stripe extents
authorJohannes Thumshirn <johannes.thumshirn@wdc.com>
Mon, 13 Jan 2025 19:31:45 +0000 (20:31 +0100)
committerDavid Sterba <dsterba@suse.com>
Tue, 14 Jan 2025 14:49:04 +0000 (15:49 +0100)
When deleting the front of a RAID stripe-extent the delete code
miscalculates the size on how much to pad the remaining extent part in the
front.

Fix the calculation so we're always having the sizes we expect.

Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/raid-stripe-tree.c

index 0c351eda3551efec67c35d76d06e648da5f33c71..9e559ad48810b704c997ff5e51222aced0b91637 100644 (file)
@@ -136,10 +136,12 @@ int btrfs_delete_raid_extent(struct btrfs_trans_handle *trans, u64 start, u64 le
                 * length to the new size and then re-insert the item.
                 */
                if (found_end > end) {
-                       u64 diff = found_end - end;
+                       u64 diff_end = found_end - end;
 
                        btrfs_partially_delete_raid_extent(trans, path, &key,
-                                                          diff, diff);
+                                                          key.offset - length,
+                                                          length);
+                       ASSERT(key.offset - diff_end == length);
                        break;
                }