pinctrl: eswin: Fix regulator error check and Kconfig dependency

Smatch reported the following warning in eic7700_pinctrl_probe():

  drivers/pinctrl/pinctrl-eic7700.c:638 eic7700_pinctrl_probe()
  warn: passing zero to 'PTR_ERR'

The root cause is that devm_regulator_get() may return NULL when
CONFIG_REGULATOR is disabled. In such case, IS_ERR_OR_NULL() triggers
PTR_ERR(NULL) which evaluates to 0, leading to passing a success code
as an error.

However, this driver cannot work without a regulator. To fix this:

 - Change the check from IS_ERR_OR_NULL() to IS_ERR()
 - Update Kconfig to explicitly select REGULATOR and
   REGULATOR_FIXED_VOLTAGE, ensuring that the regulator framework is
   always available.

This resolves the Smatch warning and enforces the correct dependency.

Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Fixes: 5b797bcc00ef ("pinctrl: eswin: Add EIC7700 pinctrl driver")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-gpio/aKRGiZ-fai0bv0tG@stanley.mountain/
Signed-off-by: Yulin Lu <luyulin@eswincomputing.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 6714aecce325879742d4665c595e97bcb61590c8..a7dd60245db7b3f74f2b44c78095e479ca8e644a 100644 (file)
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -211,6 +211,8 @@ config PINCTRL_EIC7700
        depends on ARCH_ESWIN || COMPILE_TEST
        select PINMUX
        select GENERIC_PINCONF
+       select REGULATOR
+       select REGULATOR_FIXED_VOLTAGE
        help
          This driver support for the pin controller in ESWIN's EIC7700 SoC,
          which supports pin multiplexing, pin configuration,and rgmii voltage

diff --git a/drivers/pinctrl/pinctrl-eic7700.c b/drivers/pinctrl/pinctrl-eic7700.c
index 4874b55323439acdcfba64c75f7b7e32885c79b3..ffcd0ec5c2dc6c86d0565f42e850ea270771c050 100644 (file)
--- a/drivers/pinctrl/pinctrl-eic7700.c
+++ b/drivers/pinctrl/pinctrl-eic7700.c
@@ -634,7 +634,7 @@ static int eic7700_pinctrl_probe(struct platform_device *pdev)
                return PTR_ERR(pc->base);
 
        regulator = devm_regulator_get(dev, "vrgmii");
-       if (IS_ERR_OR_NULL(regulator)) {
+       if (IS_ERR(regulator)) {
                return dev_err_probe(dev, PTR_ERR(regulator),
                                         "failed to get vrgmii regulator\n");
        }