]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: rename: return instead of goto if no cleanup required
authorNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Tue, 3 Nov 2020 07:55:19 +0000 (10:55 +0300)
committerNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Fri, 13 Nov 2020 11:49:49 +0000 (14:49 +0300)
Going to cleanup label is mere return -1 thus let's just return
instead of goto to this label.

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
src/qemu/qemu_driver.c

index 7817564c1c90f023af49516947832e12f8ea2449..9d169a8d4bf3c55e2bf6323d5c3fd4f86ee911f9 100644 (file)
@@ -19130,20 +19130,20 @@ qemuDomainRenameCallback(virDomainObjPtr vm,
                                                  new_dom_name)) ||
         !(old_dom_cfg_file = virDomainConfigFile(cfg->configDir,
                                                  vm->def->name)))
-        goto cleanup;
+        return -1;
 
     if (vm->autostart) {
         if (!(new_dom_autostart_link = virDomainConfigFile(cfg->autostartDir,
                                                           new_dom_name)) ||
             !(old_dom_autostart_link = virDomainConfigFile(cfg->autostartDir,
                                                           vm->def->name)))
-            goto cleanup;
+            return -1;
 
         if (symlink(new_dom_cfg_file, new_dom_autostart_link) < 0) {
             virReportSystemError(errno,
                                  _("Failed to create symlink '%s to '%s'"),
                                  new_dom_autostart_link, new_dom_cfg_file);
-            goto cleanup;
+            return -1;
         }
     }