]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
pinctrl: renesas: Allow the compiler to optimize away sh_pfc_pm
authorGeert Uytterhoeven <geert+renesas@glider.be>
Wed, 21 Feb 2024 11:13:59 +0000 (12:13 +0100)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Wed, 21 Feb 2024 15:34:33 +0000 (16:34 +0100)
The conversion to DEFINE_NOIRQ_DEV_PM_OPS() lost the ability of the
compiler to optimize away the struct dev_pm_ops object when it is not
needed.

Fix this by replacing the use of pm_sleep_ptr() by a custom wrapper.

Fixes: 727eb02eb753375e ("pinctrl: renesas: Switch to use DEFINE_NOIRQ_DEV_PM_OPS() helper")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/6238a78e32fa21f0c795406b6cba7bce7af92577.1708513940.git.geert+renesas@glider.be
drivers/pinctrl/renesas/core.c

index 78331d7f7cca9d8c2a6412326a3a028a1c5576a8..96d6040a8871419b98689caefc43df09c98238e7 100644 (file)
@@ -737,10 +737,12 @@ static int sh_pfc_resume_noirq(struct device *dev)
                sh_pfc_walk_regs(pfc, sh_pfc_restore_reg);
        return 0;
 }
+#define pm_psci_sleep_ptr(_ptr)        pm_sleep_ptr(_ptr)
 #else
 static int sh_pfc_suspend_init(struct sh_pfc *pfc) { return 0; }
 static int sh_pfc_suspend_noirq(struct device *dev) { return 0; }
 static int sh_pfc_resume_noirq(struct device *dev) { return 0; }
+#define pm_psci_sleep_ptr(_ptr)        PTR_IF(false, (_ptr))
 #endif /* CONFIG_ARM_PSCI_FW */
 
 static DEFINE_NOIRQ_DEV_PM_OPS(sh_pfc_pm, sh_pfc_suspend_noirq, sh_pfc_resume_noirq);
@@ -1423,7 +1425,7 @@ static struct platform_driver sh_pfc_driver = {
        .driver         = {
                .name   = DRV_NAME,
                .of_match_table = of_match_ptr(sh_pfc_of_table),
-               .pm     = pm_sleep_ptr(&sh_pfc_pm),
+               .pm     = pm_psci_sleep_ptr(&sh_pfc_pm),
        },
 };