4.19-stable patches

added patches:
	media-stkwebcam-fix-memory-leak-in-stk_camera_probe.patch

diff --git a/queue-4.19/media-stkwebcam-fix-memory-leak-in-stk_camera_probe.patch b/queue-4.19/media-stkwebcam-fix-memory-leak-in-stk_camera_probe.patch
new file mode 100644 (file)
index 0000000..c3dc8b1
--- /dev/null
+++ b/queue-4.19/media-stkwebcam-fix-memory-leak-in-stk_camera_probe.patch
@@ -0,0 +1,49 @@
+From 514e97674400462cc09c459a1ddfb9bf39017223 Mon Sep 17 00:00:00 2001
+From: Pavel Skripkin <paskripkin@gmail.com>
+Date: Wed, 7 Jul 2021 19:54:30 +0200
+Subject: media: stkwebcam: fix memory leak in stk_camera_probe
+
+From: Pavel Skripkin <paskripkin@gmail.com>
+
+commit 514e97674400462cc09c459a1ddfb9bf39017223 upstream.
+
+My local syzbot instance hit memory leak in usb_set_configuration().
+The problem was in unputted usb interface. In case of errors after
+usb_get_intf() the reference should be putted to correclty free memory
+allocated for this interface.
+
+Fixes: ec16dae5453e ("V4L/DVB (7019): V4L: add support for Syntek DC1125 webcams")
+Cc: stable@vger.kernel.org
+Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
+Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
+Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/media/usb/stkwebcam/stk-webcam.c |    6 ++++--
+ 1 file changed, 4 insertions(+), 2 deletions(-)
+
+--- a/drivers/media/usb/stkwebcam/stk-webcam.c
++++ b/drivers/media/usb/stkwebcam/stk-webcam.c
+@@ -1355,7 +1355,7 @@ static int stk_camera_probe(struct usb_i
+       if (!dev->isoc_ep) {
+               pr_err("Could not find isoc-in endpoint\n");
+               err = -ENODEV;
+-              goto error;
++              goto error_put;
+       }
+       dev->vsettings.palette = V4L2_PIX_FMT_RGB565;
+       dev->vsettings.mode = MODE_VGA;
+@@ -1368,10 +1368,12 @@ static int stk_camera_probe(struct usb_i
+ 
+       err = stk_register_video_device(dev);
+       if (err)
+-              goto error;
++              goto error_put;
+ 
+       return 0;
+ 
++error_put:
++      usb_put_intf(interface);
+ error:
+       v4l2_ctrl_handler_free(hdl);
+       v4l2_device_unregister(&dev->v4l2_dev);

diff --git a/queue-4.19/series b/queue-4.19/series
index b019849017dbec0e7c33fbdc01380d7233656687..e5edf99dac4d020a9916852ced6d73814b3ff367 100644 (file)
--- a/queue-4.19/series
+++ b/queue-4.19/series
@@ -10,3 +10,4 @@ cryptoloop-add-a-deprecation-warning.patch
 arm-8918-2-only-build-return_address-if-needed.patch
 alsa-pcm-fix-divide-error-in-snd_pcm_lib_ioctl.patch
 clk-fix-build-warning-for-orphan_list.patch
+media-stkwebcam-fix-memory-leak-in-stk_camera_probe.patch