]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
LoongArch: Do not relax against __[start|stop]_SECNAME symbol
authorLulu Cai <cailulu@loongson.cn>
Fri, 31 Jan 2025 10:37:50 +0000 (10:37 +0000)
committerNick Clifton <nickc@redhat.com>
Fri, 31 Jan 2025 10:38:14 +0000 (10:38 +0000)
bfd/elfnn-loongarch.c
ld/testsuite/ld-loongarch-elf/relax.exp
ld/testsuite/ld-loongarch-elf/start_stop.d [new file with mode: 0644]
ld/testsuite/ld-loongarch-elf/start_stop.s [new file with mode: 0644]

index c24b2600a9ad8c4f20ef91ad48a6fc6ac779714f..0e3bfac67f60d8a7d7896bf25240b0b949e9c22e 100644 (file)
@@ -5637,10 +5637,13 @@ loongarch_elf_relax_section (bfd *abfd, asection *sec,
        }
       else
        {
+         /* Do not relax __[start|stop]_SECNAME, since the symbol value
+            is not set yet.  */
          if (h != NULL
              && ((h->type == STT_GNU_IFUNC
                   && r_type != R_LARCH_CALL36)
-                 || bfd_is_abs_section (h->root.u.def.section)))
+                 || bfd_is_abs_section (h->root.u.def.section)
+                 || h->start_stop))
            continue;
 
          /* The GOT entry of tls symbols must in current execute file or
index 81924cd35cb1604f9baa4cd26044b74f128ccd63..49e6b23b6067405c187ca7c665d8f952c79a8b73 100644 (file)
@@ -412,6 +412,8 @@ if [istarget loongarch64-*-*] {
                  "relax-segment-max" \
              ] \
          ]
+
+     run_dump_test "start_stop"
     }
 
     run_ld_link_tests \
diff --git a/ld/testsuite/ld-loongarch-elf/start_stop.d b/ld/testsuite/ld-loongarch-elf/start_stop.d
new file mode 100644 (file)
index 0000000..b887dcc
--- /dev/null
@@ -0,0 +1,13 @@
+#ld: -z norelro -pie -e0
+#objdump: -d
+
+.*:     file format .*
+
+
+Disassembly of section sec1:
+
+[0-9a-f]+ <_start>:
+ [0-9a-f]+:    [0-9a-f]+       pcalau12i       \$a0, .*
+ [0-9a-f]+:    [0-9a-f]+       ld.d            \$a0, \$a0, .*
+ [0-9a-f]+:    [0-9a-f]+       pcalau12i       \$a0, .*
+ [0-9a-f]+:    [0-9a-f]+       ld.d            \$a0, \$a0, .*
diff --git a/ld/testsuite/ld-loongarch-elf/start_stop.s b/ld/testsuite/ld-loongarch-elf/start_stop.s
new file mode 100644 (file)
index 0000000..f50bc60
--- /dev/null
@@ -0,0 +1,10 @@
+       .section        sec1,"ax",@progbits
+       .globl  _start
+       .type   _start, @function
+_start:
+       la.got  $a0,__start_sec1
+       la.got  $a0,__stop_sec1
+       .size   _start, .-_start
+
+       .hidden __start_sec1
+       .hidden __stop_sec1