]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
python/samdb: fix check which checks if user is already member of group
authorBjörn Baumbach <bb@sernet.de>
Mon, 25 Nov 2024 13:05:40 +0000 (14:05 +0100)
committerBjörn Baumbach <bb@sernet.de>
Thu, 23 Jan 2025 18:53:37 +0000 (18:53 +0000)
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Jule Anger <janger@samba.org>
python/samba/samdb.py

index 4d6d9a8f5d0ed5fa104f19f9c797d30be47b63c4..96dc9171fd05ab5eb0e17637f5b3aa23400c4b96 100644 (file)
@@ -439,7 +439,7 @@ changetype: modify
                         raise Exception('Unable to find "%s". Operation cancelled.' % member)
                     targetmember_dn = targetmember[0].dn.extended_str(1)
 
-                if add_members_operation is True and (targetgroup[0].get('member') is None or get_bytes(targetmember_dn) not in [str(x) for x in targetgroup[0]['member']]):
+                if add_members_operation is True and (targetgroup[0].get('member') is None or get_bytes(targetmember_dn) not in targetgroup[0]['member']):
                     modified = True
                     addtargettogroup += """add: member
 member: %s