]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ptp: ocp: Fix typo using index 1 instead of i in SMA initialization loop
authorJiasheng Jiang <jiashengjiangcool@gmail.com>
Tue, 21 Oct 2025 18:24:56 +0000 (18:24 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 23 Oct 2025 02:18:39 +0000 (19:18 -0700)
In ptp_ocp_sma_fb_init(), the code mistakenly used bp->sma[1]
instead of bp->sma[i] inside a for-loop, which caused only SMA[1]
to have its DIRECTION_CAN_CHANGE capability cleared. This led to
inconsistent capability flags across SMA pins.

Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://patch.msgid.link/20251021182456.9729-1-jiashengjiangcool@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/ptp/ptp_ocp.c

index 794ec6e71990c8917925bd3c9c91613c2f0e753d..a5c3632529862f3019c0dbcfd8f65ea857edfab4 100644 (file)
@@ -2548,7 +2548,7 @@ ptp_ocp_sma_fb_init(struct ptp_ocp *bp)
                for (i = 0; i < OCP_SMA_NUM; i++) {
                        bp->sma[i].fixed_fcn = true;
                        bp->sma[i].fixed_dir = true;
-                       bp->sma[1].dpll_prop.capabilities &=
+                       bp->sma[i].dpll_prop.capabilities &=
                                ~DPLL_PIN_CAPABILITIES_DIRECTION_CAN_CHANGE;
                }
                return;